Fix Caching Issues #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python userbase in the setup python action was not being cached due to the path used being incorrect. I seem to recall finding the path in the setup-python or caching action docs, however I can no longer find it. It's been removed as it's not very relevant either way. The pip cache has been added to the set of cached paths. The tests' python patch version has been specified to avoid other cache misses. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
398a28a to
4611290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python userbase in the setup python action was not being cached due to the path used being incorrect. I seem to recall finding the path in the setup-python or caching action docs, however, I can no longer find it. It's been removed as it's not very relevant either way.
The pip cache has been added to the set of cached paths. The tests' python patch version has been specified to avoid other cache misses.
One of the tests was failing due to weird behavior in the underlying setup-python action. That has also been fixed.