fix: validate dictionaries (#163)

# Description

- use correct path to validation script
- do not continue on failed jobs, we don't see the error as the job is
green
- clean the workflow dictionary. It should contain the unknown words for
the copied workflows only. Otherwise an error is shown in the validation
of the related projects.

# Verification

Locally verified.

.config/dictionaries/project.txt

@@ -0,0 +1,21 @@
+amannn
+aquasecurity
+buildx
+cpus
+dockerhub
+dorny
+hlag
+hmarr
+ibiqlik
+ludeeus
+nullglob
+ossrh
+releaserc
+rhysd
+sarif
+shellcheck
+shuf
+shunsuke
+temurin
+tflint
+tfsec

.config/dictionaries/workflow.txt

@@ -1,23 +1,2 @@
-amannn
-aquasecurity
-buildx
 codeowners
-cpus
-dockerhub
-dorny
 hapag
-hlag
-hmarr
-ibiqlik
-ludeeus
-nullglob
-ossrh
-releaserc
-rhysd
-sarif
-shellcheck
-shuf
-shunsuke
-temurin
-tflint
-tfsec

.github/update_workflows.sh

@@ -167,8 +167,9 @@ echo "Updating the workflows in $destination_path"
 shopt -s nullglob
 
 # basic setup for all types
-mkdir -p "$destination_path/.github/workflows"
+mkdir -p "$destination_path/.github/workflows/scripts"
 cp .github/workflows/default_* "$destination_path/.github/workflows"
+cp .github/workflows/scripts/* "$destination_path/.github/workflows/scripts/"
 
 # move the update-workflows.sh script to the correct location (from older releases)
 if [ -f "$destination_path/update-workflows.sh" ]; then

.github/workflows/default_linter_callable.yml

@@ -71,7 +71,6 @@ jobs:
 
   lint-markdown:
     runs-on: ubuntu-latest
-    continue-on-error: true
     if: needs.find-changes-for-shell-output.outputs.markdown == 'true'
     needs: find-changes-for-shell-output
     steps:
@@ -85,7 +84,6 @@ jobs:
 
   lint-workflow:
     runs-on: ubuntu-latest
-    continue-on-error: true
     needs: find-changes-for-shell-output
     if: needs.find-changes-for-shell-output.outputs.workflow == 'true'
     container:
@@ -101,7 +99,6 @@ jobs:
 
   lint-yaml:
     runs-on: ubuntu-latest
-    continue-on-error: true
     needs: find-changes-for-shell-output
     if: needs.find-changes-for-shell-output.outputs.yaml == 'true'
     steps:
@@ -116,7 +113,6 @@ jobs:
 
   lint-json:
     runs-on: ubuntu-latest
-    continue-on-error: true
     if: needs.find-changes.outputs.json == 'true'
     needs: find-changes
     steps:
@@ -131,7 +127,6 @@ jobs:
 
   lint-renovate:
     runs-on: ubuntu-latest
-    continue-on-error: true
     if: needs.find-changes.outputs.renovate-config == 'true'
     needs: find-changes
     strategy:
@@ -155,7 +150,6 @@ jobs:
 
   lint-docker:
     runs-on: ubuntu-latest
-    continue-on-error: true
     needs: find-changes
     if: ${{ needs.find-changes.outputs.dockerfile_files != '[]' && needs.find-changes.outputs.dockerfile_files != '' }}
     strategy:

.github/workflows/default_spelling_callable.yml

@@ -33,6 +33,5 @@ jobs:
 
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
-      - run: .github/workflows/scripts/validate-dictionaries.sh
-        continue-on-error: true
+      - run: .github/workflows/scripts/check_dictionaries.sh
         if: steps.changes-for-shell.outputs.dictionaries == 'true'