Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum the second value returned from pyglowmarkt if it exist. #331

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

eknirk
Copy link
Contributor

@eknirk eknirk commented Apr 18, 2023

Description

A change in how pyglowmarkt handles timezones causes two values to be returned most of the times instead of a single value.

Motivation and Context

The above change in pyglowmarkt was not reflected and only the first value was used, which only contained data from the first our of the day. This is described in issue #330 and this PR fixes the issue.

How Has This Been Tested?

The fix has been tested on my own live system.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@HandyHat
Copy link
Owner

This is obviously not the "right" way to fix this (the right way would be to handle daylight savings properly and only ask for today's data) but in the interest of getting this integration working again, I am happy to merge this and release a new version.
Thank you so much for the PR @eknirk!

@eknirk
Copy link
Contributor Author

eknirk commented Apr 20, 2023 via email

@chesterflaps
Copy link

Can I just ask, do I just copy the code under the heading changed filed and paste it over the top of what is in my config file on HA?

I've not dealt with a pull request before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of pyglowmarkt to 0.5.5 broke ha-hildebrandglow-dcc due to change of timezone handling
3 participants