Skip to content

Commit

Permalink
Resolve loading issue related to plotly-1.4.9-min.js update in R (plo…
Browse files Browse the repository at this point in the history
  • Loading branch information
rpkyle committed Jul 31, 2019
1 parent c76d9c5 commit 55128b3
Show file tree
Hide file tree
Showing 10 changed files with 6,869 additions and 36 deletions.
8 changes: 4 additions & 4 deletions packages/dash-core-components/DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
Package: dashCoreComponents
Title: Core component suite for Dash
Version: 1.0.0
Authors @R: as.person(c(Chris Parmer <chris@plot.ly>))
Description: Core component suite for Dash
Description: Supercharged components for interactive user interfaces in Dash. A core set of components, written and maintained by the Dash team, is available in the 'dashCoreComponents' package. The source for this package is on GitHub: 'plotly/dash-core-components'.
Depends: R (>= 3.0.2)
Imports:
Suggests:
Suggests: knitr, rmarkdown
VignetteBuilder: knitr
License: MIT + file LICENSE
URL: https://github.com/plotly/dash-core-components
BugReports: https://github.com/plotly/dash-core-components/issues
Encoding: UTF-8
LazyData: true
Author: Chris Parmer [aut]
Maintainer: Chris Parmer <chris@plot.ly>
Maintainer: Ryan Patrick Kyle <ryan@plot.ly>
31 changes: 4 additions & 27 deletions packages/dash-core-components/R/internal.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,49 +2,26 @@
deps_metadata <- list(`dash_core_components` = structure(list(name = "dash_core_components",
version = "0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'plotly-1.48.3.min.js',
script = 'plotly-1.49.0.min.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashCoreComponents",
all_files = FALSE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "1.0.0", src = list(href = NULL,
version = "1", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'highlight.pack.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashCoreComponents",
all_files = FALSE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "1.0.0", src = list(href = NULL,
version = "1", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_core_components.min.js',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashCoreComponents",
all_files = FALSE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "1.0.0", src = list(href = NULL,
version = "1", src = list(href = NULL,
file = "deps"), meta = NULL,
script = 'dash_core_components.min.js.map',
stylesheet = NULL, head = NULL, attachment = NULL, package = "dashCoreComponents",
all_files = FALSE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "1.0.0", src = list(href = NULL,
file = "deps"), meta = NULL,
script = NULL,
stylesheet = 'highlight.css', head = NULL, attachment = NULL, package = "dashCoreComponents",
all_files = FALSE), class = "html_dependency"))
return(deps_metadata)
}

dash_assert_valid_wildcards <- function (attrib = list("data", "aria"), ...)
{
args <- list(...)
validation_results <- lapply(names(args), function(x) {
grepl(paste0("^", attrib, "-[a-zA-Z0-9]{1,}$", collapse = "|"),
x)
})
if (FALSE %in% validation_results) {
stop(sprintf("The following wildcards are not currently valid in Dash: '%s'",
paste(names(args)[grepl(FALSE, unlist(validation_results))],
collapse = ", ")), call. = FALSE)
}
else {
return(args)
}
}
6 changes: 6 additions & 0 deletions packages/dash-core-components/inst/doc/dash-core-components.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
## ---- include = FALSE----------------------------------------------------
knitr::opts_chunk$set(
collapse = TRUE,
comment = "#>"
)

Loading

0 comments on commit 55128b3

Please sign in to comment.