Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{FEC} Application support #857

Merged
merged 39 commits into from
Sep 10, 2019
Merged

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Sep 5, 2019

Changes:

  • New packetfilter option supported
  • Updated statistics for packet filter
  • Added support for json format also for testing apps

@ethouris ethouris mentioned this pull request Sep 5, 2019
@ethouris
Copy link
Collaborator Author

ethouris commented Sep 5, 2019

BLOCKS: #858

@ethouris ethouris added [apps] Area: Test applications related improvements Priority: Critical Status: Review Needed Type: Enhancement Indicates new feature requests labels Sep 5, 2019
@ethouris ethouris requested a review from rndi September 5, 2019 07:02
@ethouris ethouris added this to the v1.4.0 milestone Sep 5, 2019
filters["fec"] = new Creator<FECFilterBuiltin>;

ManagedPtr c = new Creator<FECFilterBuiltin>;
filters["fec"] = c;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was during the development I had a problem with the value of ManagedPtr in this operation. Now probably redundant.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I changed my mind :D

@rndi rndi merged commit d96f15e into Haivision:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[apps] Area: Test applications related improvements Priority: Critical Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants