Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed correct description for msgttl #847

Merged
merged 2 commits into from
Sep 13, 2019

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Sep 3, 2019

Fixes #661

There was a mistaken description of msgttl suggesting that the message will be waiting in the sender buffer for a chance to be sent and discarded completely after TTL passes. It was a wrong statement suggesting that the message may be not sent at all even once, which isn't true - the message is always sent at least once. The TTL value is considered only in the function that is used for retransmission.

@ethouris ethouris added Priority: Medium Type: Maintenance Work required to maintain or clean up the code Status: Review Needed [docs] Area: Improvements or additions to documentation labels Sep 3, 2019
@ethouris ethouris added this to the v1.4.0 milestone Sep 3, 2019
stay scheduled for sending for the sake of later retransmission. A message
is always sent for the first time, but the UDP packet carrying it may be
(also partially) lost. In this case, a message with a limited TTL will be
given up retransmission and discarded, if this time passes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the message is not successfully resent before its TTL expires, its retransmission is given up and it is discarded.

@rndi rndi merged commit 908e42f into Haivision:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[docs] Area: Improvements or additions to documentation Priority: Medium Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix misleading docs around message TTL
2 participants