Fixed issues, improved the app in general #53

thaflo · 2021-03-04T13:55:43Z

fixed Show save dialog on unsaved notes #13
can't reproduce UTF8 Bug #1 and UTF8 Bug #2, so maybe it's fixed. otherwise reopen an issue (this one is from 2013)
date and time are now always inserted with 2 digits
color window sets now the current note background color instantly
alarm uses the notification panel now instead of opening an alert
changed default background color to a nicer one
fixed opening selected url/ mail link strings (Firefox and
BeMail where hard coded, now it's based on the associated file_type
save background when closing background color window Note background colour is not retained, and new crashes that are probably related #51
load last note if user wishes (Settings - > load last note on startup)
shortened About Menu to one-click direct About ... menu (Was About -> About TakeNotes
... before)
Added BAbout on Deskbar Popup Menu
Added possibility to install constantly the Replicant (I didn't like that I get asked every start, so it's now settable via settings)

-color window sets now the current note background color -alarm uses the notification panel now instead of opening an alert - changed default background color to a nicer one - fixed opening selected url/ mail link strings (Firefox and BeMail where hard codet, now it's based on the associated file_type# On branch master - save background when closing background color window# Your branch is up to date with 'origin/master'. - load last note if user wishes (Settings - > load last note on startup) - shortened About Menu to one-click direct About ... menu (Was About -> About TakeNotes ... before)

-color window sets now the current note background color instantly -alarm uses the notification panel now instead of opening an alert - changed default background color to anicer one - fixed opening selected url/ mail link strings (Firefox and BeMail where hard coded, now it's based on the associated file_type -save background when closing background color window - load last note if user wishes (Settings - > load last note on startup) - shortened About Menu to one-click direct About ... menu (Was About -> About TakeNotes ... before) -- Added BAbout on Deskbar Popup Menu -- Added possibility to install constantly the Replicant (I didn't like that I get asked every start, so it's now settable via settings)

humdingerb

Also, check the coding style. There are often spaces missing, like after commas, or between "if(" etc.

source/ColorWindow.cpp

source/ColorView.cpp

source/AlarmWindow.cpp

source/Makefile

source/SettingsWindow.cpp

source/NoteView.cpp

Co-authored-by: humdinger <humdingerb@gmail.com>

I tried to unify the diff windows in one settings window, but I'm not sure if it's worth the work

Co-authored-by: humdinger <humdingerb@gmail.com>

removed BMessage if someone wants to revert color to default removed settingswindow as it was an idea to put all the settings together in one window ... I'll delay it or dismiss it Makefile removed unneeded backslash smaller fixes humdinger commented (and he was right)

…ding of the single windows

source/TakeNotes.rdef

humdingerb · 2021-03-17T07:18:42Z

source/TagsWindow.cpp

 TagsWindow :: TagsWindow(BMessage *fSaveMessage, BHandler *handler)
-		   : BWindow (BRect(300,300,700,550),"Set Tags for this note",B_TITLED_WINDOW, B_NOT_RESIZABLE){
+		   : BWindow (BRect(300,300,700,450), B_TRANSLATE("Set Tags for this note")
+		   ,B_TITLED_WINDOW, B_NOT_RESIZABLE){



The tags window should also use BLayoutBuilder and all widgets the layout-aware versions without the BRect parameter.

source/NoteWindow.cpp

humdingerb · 2021-03-17T07:30:22Z

source/NoteView.cpp

@@ -602,6 +607,7 @@ void NoteView :: _AboutRequested(){
 	about->AddAuthors(authors);
 	about->AddText(B_TRANSLATE("Distributed under the terms of the GPLv2 license"));
 	about->AddText(B_TRANSLATE("Icons by Meanwhile"));
+	about->AddExtraInfo("extra info");


Not sure why I don't find the text "extra info" displayed in the About window, but it shouldn't be in the cod ein the first place...

Hello!
In the app there are two About windows ... One for the app and one for the replicant. It's redundand, and it's visible in the replicants one. Do you have a hint how I can achieve to use one About function only instead of two?

source/ColorWindow.cpp

source/AlarmWindow.cpp

diversys · 2021-04-05T14:23:46Z

Ready for merge?

humdingerb · 2021-04-05T15:42:54Z

Besides github warning about merge conflicts, not all comments have been addressed. Esp. doing localization without using layout-aware widgets (buttons etc.) sounds like a bad idea.

thaflo · 2021-04-07T14:59:46Z

I am still working on it, so not ready yet for merge ... will use BLayout everywhere

removed some files, as they could be replaced with 2 lines of code use BString and ReadAttrString, seems more secure this are some changes, but before merging them into the master I have to do further changes

humdingerb

BTW, setting tags is crashing.

humdingerb · 2021-04-09T16:59:44Z

source/AlarmWindow.cpp

-			.Add(day)
-			.Add(month)
-			.Add(year)
+	fButtonOk = new BButton ("ok", B_TRANSLATE("Ok"), new BMessage(BUTTON_ALARM_OK));


Suggested change

fButtonOk = new BButton ("ok", B_TRANSLATE("Ok"), new BMessage(BUTTON_ALARM_OK));

fButtonOk = new BButton ("ok", B_TRANSLATE("OK"), new BMessage(BUTTON_ALARM_OK));

humdingerb · 2021-04-09T17:10:53Z

source/AlarmWindow.cpp

-	day -> SetDivider(day->StringWidth("day:") + 5);
-	month -> SetDivider(month->StringWidth("month:") + 5);
-	year -> SetDivider(year->StringWidth("year:") + 5);
+	hour = 		new BTextControl("hour",    B_TRANSLATE("hour:"), hourNow , NULL);


That's a bitof a weird indentation, isn't it? Mixing spaces and tabs... Why not use normal coding style with just one space after = and ,?
Also, I think those labels look nicer when capitalized, and having the unabbrev. "Minutes:".

Depending how much effort you wanna invest, for the date you could very well use a BCalendarView, see
haiku/headers/private/shared/CalendarView.h
The time might use a BSpinner for easy in/decreasing.

But as I said, I'm OK if you don't feel like sinking time into that... :)

humdingerb · 2021-04-09T17:12:14Z

source/AlarmWindow.cpp

+	BView* fTopView = new BGroupView(B_VERTICAL);
+
+	BLayoutBuilder::Group<>(fTopView, B_VERTICAL)
+		.SetInsets(5,5,5,5)


haiku/headers/os/interface/InterfaceDefs.h has some constants to use for insets, e.g.:

Suggested change

.SetInsets(5,5,5,5)

.SetInsets(B_USE_WINDOW_INSETS)

humdingerb · 2021-04-09T17:18:10Z

source/ColorWindow.cpp

+	BView* topView = new BGroupView(B_VERTICAL);
+
+	BLayoutBuilder::Group<>(topView, B_VERTICAL, 0.0f)
+		.SetInsets(5,5,5,5)


As above:

Suggested change

.SetInsets(5,5,5,5)

.SetInsets(B_USE_WINDOW_INSETS)

humdingerb · 2021-04-09T17:19:14Z

source/TagsWindow.cpp

+	BString tagtwo = BString();
+	BString tagthree = BString();
+
+	fTag1 = new BTextControl("tag1", B_TRANSLATE("First Tag: "), NULL, NULL);


Suggested change

fTag1 = new BTextControl("tag1", B_TRANSLATE("First Tag: "), NULL, NULL);

fTag1 = new BTextControl("tag1", B_TRANSLATE("First tag:"), NULL, NULL);

Same for the following lines.

humdingerb · 2021-04-09T17:20:07Z

source/TagsWindow.cpp

+	BView* fTopView = new BGroupView(B_VERTICAL);
+
+	BLayoutBuilder::Group<>(fTopView, B_VERTICAL)
+		.SetInsets(5,5,5,5)


Same again:

Suggested change

.SetInsets(5,5,5,5)

.SetInsets(B_USE_WINDOW_INSETS)

alarm window uses BSpinner now (BCalendarView for the day/month/year will follow cleaned up a lot of the code in AlarmWindow.cpp

humdingerb · 2021-04-16T06:11:23Z

I would say we should merge now, but github claims merge confilcts. Can you have a look?
We should do smaller PRs in the future and merge quicker...

thaflo · 2021-04-17T08:54:48Z

I would say we should merge now, but github claims merge confilcts. Can you have a look?
That's okay for me. I can't see merge conflicts, maybe I don't know how to check that. Any hints?

We should do smaller PRs in the future and merge quicker...
Okay

humdingerb · 2021-04-17T11:58:07Z

I just merged the PR branch locally, and got no conflicts either. Nevertheless, on this page github says:

This branch cannot be rebased due to conflicts
Rebasing the commits of this branch on top of the base branch cannot be performed automatically due to conflicts encountered while reapplying the individual commits from the head branch.

I'll try pushing the locally merged branch to master... Let's see...

humdingerb · 2021-04-17T12:02:46Z

That seems to have worked.
In the future, smaller PRs, please. And try to keep commits separated, i.e. fixes in one commit, new features in another, style fixes in a separate one as well etc. "git rebase -i" can also be helpful to re-order and squash commits.

thaflo added 5 commits December 22, 2020 22:27

make translatable

e3e6333

added a "new note" feature

5ab7161

some cleanups

869288d

thaflo changed the title ~~Fixed issues, improved the app in general (I think :-) )~~ Fixed issues, improved the app in general Mar 4, 2021

humdingerb reviewed Mar 5, 2021

View reviewed changes

thaflo and others added 9 commits March 6, 2021 10:19

Update source/NoteView.cpp

1bf9437

Co-authored-by: humdinger <humdingerb@gmail.com>

Update source/SettingsWindow.cpp

9ed2b36

Co-authored-by: humdinger <humdingerb@gmail.com>

Update source/SettingsWindow.cpp

fa088d6

Co-authored-by: humdinger <humdingerb@gmail.com>

Update source/NoteView.cpp

b39510a

Co-authored-by: humdinger <humdingerb@gmail.com>

Delete SettingsWindow.h

653c6ec

I tried to unify the diff windows in one settings window, but I'm not sure if it's worth the work

Update source/AlarmWindow.cpp

8ce2f37

Co-authored-by: humdinger <humdingerb@gmail.com>

some cleanup and more changes regarding easier handling and understan…

52e4b30

…ding of the single windows

test

3b36220

humdingerb reviewed Mar 17, 2021

View reviewed changes

added BLayout Management to "tags" and "set alarm" windows

839d3b6

removed some files, as they could be replaced with 2 lines of code use BString and ReadAttrString, seems more secure this are some changes, but before merging them into the master I have to do further changes

humdingerb reviewed Apr 9, 2021

View reviewed changes

tags window is working again

772c32e

alarm window uses BSpinner now (BCalendarView for the day/month/year will follow cleaned up a lot of the code in AlarmWindow.cpp

thaflo closed this Apr 17, 2021

thaflo reopened this Apr 17, 2021

humdingerb closed this Apr 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed issues, improved the app in general #53

Fixed issues, improved the app in general #53

thaflo commented Mar 4, 2021 •

edited

Loading

humdingerb left a comment

humdingerb Mar 17, 2021

humdingerb Mar 17, 2021

thaflo Mar 23, 2021

diversys commented Apr 5, 2021

humdingerb commented Apr 5, 2021

thaflo commented Apr 7, 2021

humdingerb left a comment

humdingerb Apr 9, 2021

humdingerb Apr 9, 2021

humdingerb Apr 9, 2021

humdingerb Apr 9, 2021

humdingerb Apr 9, 2021

humdingerb Apr 9, 2021

humdingerb commented Apr 16, 2021

thaflo commented Apr 17, 2021

humdingerb commented Apr 17, 2021

humdingerb commented Apr 17, 2021

	fButtonOk = new BButton ("ok", B_TRANSLATE("Ok"), new BMessage(BUTTON_ALARM_OK));
	fButtonOk = new BButton ("ok", B_TRANSLATE("OK"), new BMessage(BUTTON_ALARM_OK));

	fTag1 = new BTextControl("tag1", B_TRANSLATE("First Tag: "), NULL, NULL);
	fTag1 = new BTextControl("tag1", B_TRANSLATE("First tag:"), NULL, NULL);

Fixed issues, improved the app in general #53

Fixed issues, improved the app in general #53

Conversation

thaflo commented Mar 4, 2021 • edited Loading

humdingerb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diversys commented Apr 5, 2021

humdingerb commented Apr 5, 2021

thaflo commented Apr 7, 2021

humdingerb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

humdingerb commented Apr 16, 2021

thaflo commented Apr 17, 2021

humdingerb commented Apr 17, 2021

humdingerb commented Apr 17, 2021

thaflo commented Mar 4, 2021 •

edited

Loading