Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid crash w/ remove maint flag; fix: reserve extra vram with high vram models #408

Merged
merged 4 commits into from
Jan 26, 2025

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Jan 26, 2025

  • fix: avoid crash w/ remove maint flag if worker didn't exist

    • The worker is only registered after the first job pop. Prior to this change, if the worker operator happens to have this set when changing worker name, the worker would crash and exit on start up. As this isn't really an unrecoverable scenario (we can just skip exiting maint mode in this case), I've added a try/except to warn on whatever did happen but to continue anyway.
  • fix: reserve extra vram with high vram models

    • This makes it so if high_memory_mode is on and there are big models (flux, cascade), a total of 6gb of VRAM will be reserved (per thread) to try and limit the possibility of CUDA OOMs.

@tazlin tazlin merged commit b45f087 into main Jan 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant