docs: Fix missing setup instructions #377
Conversation
|
Nowhere do the instructions explain that you first need python and pip
either. If this is really going to take of with mainstream then an
installer should take care of it.
…On Sat, 21 Dec 2024, 06:24 Joey Parrish, ***@***.***> wrote:
Nowhere in the README or the bridge data template did it mention that the
worker names needed to be unique. However, using the default names led to
the error "Wrong credentials to submit as this worker." I found the cause
on Reddit.
This adds brief notes to both the README and the template file to try to
guide people explicitly on this point. Had these notes been present, I
would not have made the mistake of keeping the defaults.
------------------------------
You can view, comment on, or merge this pull request online at:
#377
Commit Summary
- e0d8576
<e0d8576>
docs: Fix missing setup instructions
File Changes
(2 files <https://github.com/Haidra-Org/horde-worker-reGen/pull/377/files>
)
- *M* README.md
<https://github.com/Haidra-Org/horde-worker-reGen/pull/377/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(1)
- *M* bridgeData_template.yaml
<https://github.com/Haidra-Org/horde-worker-reGen/pull/377/files#diff-854fa71f4847b9cdb3ef482398decc3445b5d83e45ecbf44bcd2679857c3b89b>
(3)
Patch Links:
- https://github.com/Haidra-Org/horde-worker-reGen/pull/377.patch
- https://github.com/Haidra-Org/horde-worker-reGen/pull/377.diff
—
Reply to this email directly, view it on GitHub
<#377>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3KICQQ6MTDEB7SQZS3FS7T2GTURJAVCNFSM6AAAAABUAHYVPSVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42TGNZUHEYTQNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Nowhere in the README or the bridge data template did it mention that the worker names needed to be unique. However, using the default names led to the error "Wrong credentials to submit as this worker." I found the cause on Reddit. This adds brief notes to both the README and the template file to try to guide people explicitly on this point. Had these notes been present, I would not have made the mistake of keeping the defaults.
1a45d17 to
2bce23d
Compare
This bridgeData_template file dates back to the repo that regen replaces (https://github.com/Haidra-Org/AI-Horde-Worker) which did support these other worker modes.
Thanks for taking the initiative to open an PR. Its plain to see that this is confusing behavior, so the change is welcome. |
Your situation was highly specific and we put a great deal of effort into trying to make it easier for you. However, please note that there is no requirement to already have python on machine, and that there is an installer for both windows and linux and even AMD/RoCm that does in fact handle installing everything required. In the specific cases that you would need to install python, as mentioned in the main docs and explained here, we do explain that you need python first. If you have any further specific problems, or if you feel the docs are still insufficient, feel free to open an issue with a more specific request. |
Nowhere in the README or the bridge data template did it mention that the worker names needed to be unique. However, using the default names led to the error "Wrong credentials to submit as this worker." I found the cause on Reddit.
This adds brief notes to both the README and the template file to try to guide people explicitly on this point. Had these notes been present, I would not have made the mistake of keeping the defaults.