-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROCm in WSL #346
ROCm in WSL #346
Conversation
9d5dd3a
to
28bc634
Compare
Consider merging #347 before this, since this PR has been tested on top of it. |
13a8649
to
8898789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this as is; the functional change to the scripts should only affect WSL and the doc changes can be iterated on if needed. I can't step-by-step confirm that it works as reported, as I don't have access to an AMD machine, but it looks reasonable and I'd rather merge now so the git history doesn't keep diverging.
I've tested a blind copy/paste of the commands from the Initially activating WSL is hard to test if it has been installed before, but if we get any questions around that it's just a Readme change to correct. The library patch should continue to work unless the "recommended" way to deal with this changes upstream or there are incompatible Driver/Kernel upgrades. |
Agreed on all. Thanks again for your work on this and all your other initiatives. |
This is a first draft. Feedback on the clarity of descriptions, level of detail and questions left open is welcome.
The WSL-Patch needs a bit more testing to make sure it runs reliably.
flash_attn integration is also flaky as of now.
Memory usage, as usual on Linux systems is suboptimal, WSL memory overhead makes this even more obvious.