fix: delete conda dir and micromamba.exe if legacy version installed #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change from `micromamba.bat` to `mamba.bat` isn't worth supporting backwards for. Running update-runtime already has the practical effect of reinstalling micromamba's conda venv, so it should be generally seen as safe to remove the directory as its rooted to the script folder and should otherwise be seen as managed by the worker code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change from
micromamba.battomamba.batisn't worth supporting backwards for. Running update-runtime already has the practical effect of reinstalling micromamba's conda venv, so it should be generally seen as safe to remove the directory as its rooted to the script folder and should otherwise be seen as managed by the worker code.