Skip to content

Commit

Permalink
ci/fix: use github action for hadolint instead
Browse files Browse the repository at this point in the history
There is some sort of incompatibility with the hadolint pre-commit hook in a github workflow. I am just going to stick to the github action for now.
  • Loading branch information
tazlin committed Nov 4, 2024
1 parent 124d7d6 commit 38fee17
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 4 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/maintests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,19 @@ jobs:
with:
extra_args: --all-files

dockerfile-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Lint CUDA Dockerfile
uses: hadolint/hadolint-action@master
with:
dockerfile: "Dockerfiles/Dockerfile.cuda"
- name: Lint RoCM Dockerfile
uses: hadolint/hadolint-action@master
with:
dockerfile: "Dockerfiles/Dockerfile.rocm"

unit-tests:
runs-on: ubuntu-latest
strategy:
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/prtests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,19 @@ jobs:
with:
extra_args: --all-files

dockerfile-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Lint CUDA Dockerfile
uses: hadolint/hadolint-action@master
with:
dockerfile: "Dockerfiles/Dockerfile.cuda"
- name: Lint RoCM Dockerfile
uses: hadolint/hadolint-action@master
with:
dockerfile: "Dockerfiles/Dockerfile.rocm"

unit-tests:
runs-on: ubuntu-latest
strategy:
Expand Down
4 changes: 0 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ repos:
rev: v0.7.2
hooks:
- id: ruff
- repo: https://github.com/hadolint/hadolint
rev: v2.12.0
hooks:
- id: hadolint
- repo: https://github.com/pre-commit/mirrors-mypy
rev: 'v1.13.0'
hooks:
Expand Down

0 comments on commit 38fee17

Please sign in to comment.