Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check linting and validate that convert.py was run #16

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Apr 26, 2024

This is to facilitate new contributors to this repo as @henk717 will be stepping away from regularly maintaining the models list. @candre23 will be the primary beneficiary of this change but there is a potential that others may end up stepping in.

To simplify this, the changes in this PR will cause github workflows to run which check:

  • That whitespace formatting is correct (file line endings, no extra whitespace, etc)
  • That *.csv and *.json files are well-formed
  • That running convert.py would result in the exact db.json file that is currently in the repo
    • For PRs, this checks that the incoming models.csv matches the incoming db.json.

@tazlin tazlin merged commit 6f2408b into Haidra-Org:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant