-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump stylelint-config-standard from 36.0.1 to 37.0.0 #5343
chore(deps-dev): bump stylelint-config-standard from 36.0.1 to 37.0.0 #5343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumps [stylelint-config-standard](https://github.com/stylelint/stylelint-config-standard) from 36.0.1 to 37.0.0. - [Release notes](https://github.com/stylelint/stylelint-config-standard/releases) - [Changelog](https://github.com/stylelint/stylelint-config-standard/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint-config-standard@36.0.1...37.0.0) --- updated-dependencies: - dependency-name: stylelint-config-standard dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
a178378
to
65ce5c8
Compare
@martijnrusschen, I analyzed this issue and we are getting lint errors in all the places where we combine css values combinded with scss variable. I think it's a bug in their validation logic - stylelint-scss/stylelint-scss#1017 (comment) I found a workaround for it. If we directly use these combined values on css properties only we're getting an error. But if we create a seperate scss variable with the combined values and use it in the css property means it's working fine. E.g.
I'll raise a PR with this workaround, let me know if you have any suggestions. |
…h scss variable - due to an update of "stylelint-config-standard" to v37 #5343 (comment)
Hi @martijnrusschen, I added a fix for the lint issue in this PR - #5348 Let me know if you need any changes. |
🎨♻️ Fix lint errors of combine css values combined with scss variable - due to an update of "stylelint-config-standard" to v37
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5343 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 30 30
Lines 3358 3358
Branches 1414 1427 +13
=======================================
Hits 3253 3253
+ Misses 105 103 -2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
NIce one! |
Bumps stylelint-config-standard from 36.0.1 to 37.0.0.
Release notes
Sourced from stylelint-config-standard's releases.
Changelog
Sourced from stylelint-config-standard's changelog.
Commits
aca7a9f
37.0.0ff3d6b9
Prepare 37.0.0 (#346)f8e1d22
Document browser support policy based on Baseline Widely Available (#345)72ae9dc
Bump the development-dependencies group with 3 updates (#344)c98f4c3
Bump nanoid from 3.3.7 to 3.3.8 (#343)14a2545
Add ESLint to dependabot dev group (#342)551609a
Bump eslint from 9.14.0 to 9.16.0 (#341)2392231
Bump the development-dependencies group with 3 updates (#340)22a0eb6
Bump cross-spawn (#339)3a0ef2a
Bump eslint-config-stylelint from 22.0.0 to 23.0.0 in the development-depende...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)