Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NodeJS 18 in CI #4134

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Use NodeJS 18 in CI #4134

merged 2 commits into from
Jul 11, 2023

Conversation

Zarthus
Copy link
Contributor

@Zarthus Zarthus commented Jul 11, 2023

Refs #4107

Refs #4133

pullrequest[bot]
pullrequest bot reviewed Jul 11, 2023
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the pull request is a draft.

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #4134 (3e3bb8c) into master (d50a9d9) will not change coverage.
The diff coverage is n/a.

❗ Current head 3e3bb8c differs from pull request most recent head 4768034. Consider uploading reports for the commit 4768034 to get more accurate results

@@           Coverage Diff           @@
##           master    #4134   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files          20       20           
  Lines        1890     1890           
  Branches      458      458           
=======================================
  Hits         1777     1777           
  Misses         40       40           
  Partials       73       73

@Zarthus Zarthus marked this pull request as ready for review July 11, 2023 08:16
pullrequest[bot]
pullrequest bot reviewed Jul 11, 2023
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.

@Zarthus you can click here to see the review status or cancel the code review job.

pullrequest[bot]
pullrequest bot reviewed Jul 11, 2023
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 6
- 5

73% GitHubActions
18% GitHubActions (tests)
9% JSON

Generated lines of change

+ 12
- 2

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

@Zarthus Zarthus merged commit d5da11a into master Jul 11, 2023
martijnrusschen
martijnrusschen reviewed Jul 11, 2023
View reviewed changes
docs-site/package.json
@@ -32,6 +32,7 @@
]
},
"devDependencies": {
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add this on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - it silences the warning as suggested in the notice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove it if we switch to something else than react-app-rewired.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness sake; I added it as a checkpoint into #4133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnrusschen martijnrusschen martijnrusschen left review comments

@pullrequest pullrequest[bot] pullrequest[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zarthus @martijnrusschen