Fix: Screen reader does not announce selected date, current month #3817
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3817 +/- ##
==========================================
- Coverage 94.66% 94.59% -0.08%
==========================================
Files 20 20
Lines 1651 1684 +33
Branches 390 404 +14
==========================================
+ Hits 1563 1593 +30
- Misses 25 27 +2
- Partials 63 64 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@martijnrusschen Do I need to add more tests to increase the code-coverage and only then will you review this PR, right? |
| }`; | ||
| } else { | ||
| if (this.props.showTimeSelectOnly) { | ||
| ariaLiveMessage = `Selected time: ${safeDateFormat( |
There was a problem hiding this comment.
Hardcoded english texts will ruin accessibility for all non-english users. This prefix should be diffferent prop.
|
Can you resolve the merge conflict so we can get this merged and released? |
…selected-date-announce
| @@ -1004,6 +1040,7 @@ export default class Calendar extends React.Component { | |||
| showPopperArrow={this.props.showPopperArrow} | |||
| arrowProps={this.props.arrowProps} | |||
| > | |||
| {this.renderAriaLiveRegion()} | |||
There was a problem hiding this comment.
Shouldn't this span be optional?
There was a problem hiding this comment.
Agreed, this ariaLiveRegion should be optional
There was a problem hiding this comment.
is this the double Month Year we see now?
There was a problem hiding this comment.
Ah noo, this is already covered here :( #3924
There was a problem hiding this comment.
I agree, this should be optional. This is showing up in my application and I cannot opt out of showing the "Selected date:" text.
…unce Fix: Screen reader does not announce selected date, current month
This PR fixes some accessibility issues, and may help screen reader users navigate this datepicker library better.
I believe that my PR will resolve these issue:
#3558
#3559
#3766