Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New de-shuffle test (was "imagecodecs and hdf5plugin packages") #90

Merged
merged 9 commits into from
Aug 27, 2021

Conversation

ajelenak
Copy link
Contributor

Added these two Python packages with additional codecs. imagecodecs provides codecs used in many TIFF-based formats.

@jreadey
Copy link
Member

jreadey commented Jul 7, 2021

Does this provide bitshuffle compression as well? i.e. fix for #76
Beyond the dockerfile changes, I guess storUtil.py will need to be updated.

@ajelenak
Copy link
Contributor Author

ajelenak commented Jul 8, 2021

Yes, it should.

@ajelenak ajelenak changed the title imagecodecs and hdf5plugin packages New de-shuffle test (was "imagecodecs and hdf5plugin packages") Aug 27, 2021
@ajelenak
Copy link
Contributor Author

The main addition to this PR is a new de-shuffle test using an HDF5 file with known data. This required a fix to decouple detection of shuffle and compression filters. Several Python files had code reformatted for style or clarity. The main HSDS service Dockerfile was updated (and still includes the new compression packages as per original PR's intention).

Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants