Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows build and test to github workflows #326

Merged
merged 10 commits into from
Apr 1, 2024
Merged

Add windows build and test to github workflows #326

merged 10 commits into from
Apr 1, 2024

Conversation

mattjala
Copy link
Contributor

The stdout reconfigure is necessary because python attempts to use the windows 1252 encoding by default on (some versions of) windows, which gets an encoding error in the UTF-8 specific tests.

@mattjala mattjala added the ci/cd Issues related to the CI/CD setup and execution label Mar 15, 2024
@mattjala mattjala requested a review from jreadey March 15, 2024 21:15
@mattjala mattjala self-assigned this Mar 15, 2024
jreadey
jreadey reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does the sys.stdout.reconfigure call get executed? Seems weird to be just dangling in this file. Does it absolutely need to run before any other code?
Otherwise, you can drop it into: basenode.py - baseInit().

@mattjala mattjala force-pushed the windows_CI branch 8 times, most recently from a1f9542 to ad9f54a Compare March 26, 2024 14:51
@mattjala mattjala force-pushed the windows_CI branch 2 times, most recently from 107af79 to a8b3db0 Compare March 26, 2024 15:08
@mattjala
Copy link
Contributor Author

mattjala commented Mar 26, 2024 •
edited
Loading

  • Added workflows to test h5pyd.

@mattjala mattjala mentioned this pull request Apr 1, 2024
Closed
jreadey
jreadey approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jreadey jreadey merged commit 4b9a4a0 into HDFGroup:master Apr 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreadey jreadey jreadey approved these changes

Assignees

@mattjala mattjala

Labels
ci/cd Issues related to the CI/CD setup and execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjala @jreadey