Don't use a nonliteral format string in test/fheap.c:begin_test(). #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use snprintf. Don't duplicate a string on the heap unnecessarily.
Merged
| HDassert(del_str); | ||
| test_desc = (char *)H5MM_malloc(HDstrlen(del_str) + HDstrlen(base_desc)); | ||
| HDsprintf(test_desc, base_desc, del_str); | ||
| size_t test_desc_len = strlen(base_desc) + sizeof(" ") + strlen(del_str); |
There was a problem hiding this comment.
Think this might need an extra +1 for the NUL terminator.
| /* Remove half of total objects from heap */ | ||
| if (tparam->del_dir == FHEAP_DEL_FORWARD) | ||
| if (tparam->drain_half == FHEAP_DEL_DRAIN_ALL) | ||
| str = H5MM_strdup("(all - forward)"); | ||
| return "(all - forward)"; |
There was a problem hiding this comment.
I'm all for removing memory allocations where they aren't really needed!
|
On Fri, Jan 28, 2022 at 02:47:17PM -0800, jhendersonHDF wrote:
@jhendersonHDF commented on this pull request.
>
/*
* Test filling & removing all (small) objects from root direct block of absolute heap
*/
- del_str = get_del_string(tparam);
- HDassert(del_str);
- test_desc = (char *)H5MM_malloc(HDstrlen(del_str) + HDstrlen(base_desc));
- HDsprintf(test_desc, base_desc, del_str);
+ size_t test_desc_len = strlen(base_desc) + sizeof(" ") + strlen(del_str);
Think this might need an extra +1 for the NUL terminator.
sizeof(" ") includes the NUL terminator of " ".
Dave
|
Ah that's true. I mistakenly read as strlen(" "). |
jhendersonHDF
approved these changes
Jan 28, 2022
lrknox
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.