Skip to content

Commit

Permalink
#469 Clean up soft-deleted timereports during employee order deletion.
Browse files Browse the repository at this point in the history
Added a repository method to hard delete soft-deleted timereports by employee order ID. Ensured these records are removed before allowing the deletion of the associated employee order, improving data consistency.
  • Loading branch information
KlausRicharz committed Jan 17, 2025
1 parent 17f316a commit dd69a12
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
import java.util.Optional;
import org.hibernate.jpa.HibernateHints;
import org.springframework.data.jpa.repository.JpaSpecificationExecutor;
import org.springframework.data.jpa.repository.Modifying;
import org.springframework.data.jpa.repository.NativeQuery;
import org.springframework.data.jpa.repository.Query;
import org.springframework.data.jpa.repository.QueryHints;
import org.springframework.data.repository.CrudRepository;
Expand Down Expand Up @@ -138,4 +140,8 @@ where tr.employeeorder.id in (:ids) group by tr.employeeorder.id
""")
List<Long[]> getReportedMinutesForEmployeeordersAsMap(List<Long> ids);

@Modifying
@NativeQuery("DELETE FROM timereport t WHERE t.employeeorder_id = :employeeorderId and t.deleted = true")
int hardDeleteSoftDeletedByEmployeeorderId(Long employeeorderId);

}
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,8 @@ void onEmployeeorderDelete(EmployeeorderDeleteEvent event) {
.toList();
event.veto(errors);
}
var deletedCount = timereportRepository.hardDeleteSoftDeletedByEmployeeorderId(employeeorderId); // ensure no soft deleted timereport exists
log.info("{} soft deleted timereports were deleted to allow deletion of employee order {}.", deletedCount, employeeorderId);
}

@EventListener
Expand Down

0 comments on commit dd69a12

Please sign in to comment.