Improving to make it more idiomatic #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [+] fix(init_const.go): fix typo in error message variable name
- [+] fix(worker): handle error in listPods function using idiomatic Go error handling - [+] refactor(worker): update error message format in listPods function
- [+] chore(init_const.go): fix typo in error message for FailedTOScallEdDeployment - [+] feat(init_const.go): add CompassEmoji constant for a compass emoji
- [+] chore(init_const.go): add error constants for sailing ships and task attempts
- [+] refactor(helper.go): refactor logTaskStart function to combine emojis with a space for readability - [+] refactor(helper.go): refactor logErrorWithFields function to combine emojis with a space for readability - [+] feat(helper.go): add withRetries function to handle retrying an operation with a specified number of attempts and delay - [+] feat(helper.go): add attemptOperation function to attempt an operation and handle errors - [+] feat(helper.go): add waitForNextAttempt function to wait for the next attempt with a specified delay
- [+] fix(crew.go): add taskStatus parameter to performTaskWithRetries function - [+] feat(crew.go): add operation function to perform task with retries and return task name along with error - [+] feat(crew.go): use withRetries helper function to perform operation with retries - [+] fix(crew.go): handle failure if operation fails after retries and return error message - [+] fix(crew.go): handle success if operation is successful
- [+] fix(scale.go): fix typo in error message constant name from FailedTOScallEdDeployment to FailedToScaleDeployment
- [+] docs(worker/helper.go): add documentation for withRetries function - [+] docs(worker/helper.go): add documentation for attemptOperation function - [+] docs(worker/helper.go): add documentation for waitForNextAttempt function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.