Refactor Codebase to Simplicity #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [+] feat(init_const.go): add ErrorParameterMustBestring constant to handle string parameter validation with additional error message
- [+] refactor(crew.go): refactor resolveConflict function to use getParamAsString helper function
- [+] fix(update_network_policy.go): fix error handling and use getParamAsString function for policyName and policySpec - [+] refactor(update_network_policy.go): refactor extractNetworkPolicyParameters function
- [+] fix(update_image.go): refactor extractDeploymentParameters function to use getParamAsString function for parameter extraction and handle error cases properly
- [+] fix(labels_pods.go): fix typo in variable name 'labelKey' and 'labelValue' - [+] refactor(labels_pods.go): extract common code into 'getParamAsString' function - [+] refactor(labels_pods.go): improve error handling and error messages in 'extractLabelParameters' function
- [+] fix(worker/tasks_crew.go): fix typo in parameter names and error messages - [+] refactor(worker/tasks_crew.go): use helper functions to get parameters as string and int
- [+] chore(init_const.go): add new error message for parameter not found
- [+] refactor(list_options.go): remove unused functions getParamAsString and getParamAsInt64
- [+] feat(worker): add helper functions to retrieve string and integer values from a map of parameters - [+] - Added getParamAsString function to retrieve a string value from a map based on a key - [+] - Added getParamAsInt64 function to retrieve an integer value from a map based on a key, handling both int and float64 data types - [+] - Added getParamAsInt function to retrieve an integer value from a map of parameters, handling both float64 and int types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This Simplicity are powerful