Enhancement Multiple-Task when use Lot's of Worker #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [+] feat(worker): add TrackTask struct to keep track of claimed tasks - [+] feat(worker): add NewTaskStatusMap function to create a new TaskStatusMap - [+] feat(worker): add Claim method to claim a task in TaskStatusMap - [+] feat(worker): add Release method to mark a task as unclaimed in TaskStatusMap
- [+] chore(init_const.go): add new constant for task number mismatch error message
- [+] refactor(logger.go): remove unnecessary variable assignment and use defer to unlock mutex - [+] fix(logger.go): fix incorrect log level in LogErrorWithEmoji function
- [+] feat(crew.go): add support for task claiming and releasing in CrewWorker function - [+] fix(crew.go): fix variable name shipsnamespace to shipsNamespace in CrewWorker function - [+] fix(crew.go): fix variable name shipsnamespace to shipsNamespace in performTaskWithRetries function - [+] fix(crew.go): fix variable name shipsnamespace to shipsNamespace in logFinalError function - [+] fix(crew.go): fix error message format in results channel
- [+] chore(init_const.go): add Worker_Name constant
- [+] refactor(captain.go):
- Remove unused imports for "language" and "navigator" packages.
- Replace the logger setup for each worker from "navigator.Logger" to "zap.L().With(zap.Int("worker", workerIndex))".
- Remove the call to "navigator.SetLogger(workerLogger)" as it is no longer needed.
- Update the call to "CrewWorker" to include the "taskStatus" parameter.
- [+] docs(README.md): update note to reflect support for multiple tasks and multiple workers
- [+] chore(README.md): update TODO list with more descriptive and specific tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.