This repository has been archived by the owner on Jan 20, 2025. It is now read-only.
Fix [Golang] [Package] [Module] Main Command & FileSystem #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [+] feat(file_system.go): add ReadFile method to FileSystem interface - [+] fix(file_system.go): change receiver name from fs to rfs in Create and WriteFile methods - [+] feat(file_system.go): implement ReadFile method in RealFileSystem - [+] feat(file_system_mock.go): add Files map and ReadFile method to MockFileSystem - [+] feat(file_system_mock.go): add NewMockFileSystem function - [+] fix(main.go): change repairJSONData signature to accept FileSystem interface - [+] fix(main.go): pass RealFileSystem instance to repairJSONData - [+] fix(main.go): change saveToFile signature to accept FileSystem interface - [+] fix(main.go): pass FileSystem interface instance to saveToFile - [+] fix(main_test.go): change mockFS variable to use NewMockFileSystem function - [+] fix(main_test.go): change repairedPath assertion to include file extension - [+] fix(main_test.go): change repairedPath assertion to include file extension - [+] fix(main_test.go): change WriteFileCalled assertion to check if true - [+] fix(main_test.go): change WriteFilePath assertion to
- [+] chore(GopherCI.yml): add support for Windows in the matrix for both jobs
|
CodeQL analysis is complete for PR #22 |
- [+] fix(main.go): change the repaired file path to prepend "repaired_" to the original file name - [+] fix(main_test.go): change the name of the repaired file to "repaired_testing.json"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.