Added border and background color customization #68
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProMix0
reviewed
Sep 15, 2024
| @@ -27,6 +27,9 @@ Options: | |||
| -r, --raw output raw image data to stdout | |||
| -t, --notif-timeout notification timeout in milliseconds (default 5000) | |||
| --clipboard-only copy screenshot to clipboard and don't save image in disk | |||
| --border-width width of the selection border in pixels (default 2) | |||
There was a problem hiding this comment.
You added an option to --help, but it's not implemented?
There was a problem hiding this comment.
Yup. I absolutely did. Added the border width option because it's not that difficult.
Matt-FTW
added a commit
to Matt-FTW/dotfiles
that referenced
this pull request
Sep 20, 2024
code extracted from Gustash/Hyprshot#68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 new parameters to change the color around the selected region and border color and width
Closes issue #60