Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #38 #39

Merged
merged 1 commit into from
Jun 1, 2024
Merged

close #38 #39

merged 1 commit into from
Jun 1, 2024

Conversation

ProMix0
Copy link
Contributor

@ProMix0 ProMix0 commented Mar 29, 2024

Calculate min width/height similar to max

@Gustash
Copy link
Owner

Gustash commented Mar 30, 2024

Are you sure this works as intended? Have you tested it with negative offsets?

If so, it's not min width or height, x and y are positions.

@ProMix0
Copy link
Contributor Author

ProMix0 commented Mar 30, 2024

Are you sure this works as intended?

I hope

Have you tested it with negative offsets?

Yes, I did. Region, window and output, even for partial outside floating windows

If so, it's not min width or height, x and y are positions.

Yes, you right, it's positions, not width/height

@CharlesAttend
Copy link

I also had this bug when using negative value and transforms. I tried with the @ProMix0 fix and it worked correctly has intended.

My configuration just in case.

monitor=eDP-1,preferred,760x1440,1
monitor=DP-4,3440x1440@100,0x0,auto
monitor=DP-5,preferred,-1080x-115,auto,transform,3

@Ben9986
Copy link

Ben9986 commented May 6, 2024

Just wanted to add this PR fixed the issues i was having with dual monitors. Can it be merged? Would simplify my nix install...

@Gustash Gustash merged commit 054b896 into Gustash:main Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants