Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --clipboard-mode option #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add --clipboard-mode option #37

wants to merge 2 commits into from

Conversation

Sryther
Copy link

@Sryther Sryther commented Mar 9, 2024

Add the possibility to avoid using clipboard copy.

@ProMix0
Copy link
Contributor

ProMix0 commented Mar 9, 2024

Does it interfere with clipboard-only option? Maybe more general approach with kinda clipboard modes should be used?

@Sryther
Add --clipboard-mode option
0aedcc1 
Deprecate --clipboard-only option
@Sryther Sryther changed the title Add --no-clipboard option Add --clipboard-mode option Mar 11, 2024
@Sryther
Copy link
Author

Sryther commented Mar 11, 2024

Thanks for you feedback.
I changed the way clipboard options are supported to have only one: --clipboard-mode which accepts always (default), no and only.

Gustash
Gustash requested changes Jun 1, 2024
View reviewed changes
Copy link
Owner

@Gustash Gustash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the semantics of --clipboard-mode. I honestly think the user API should be --clipboard-only and --no-clipboard. Internally you can keep the CLIPBOARD_MODE variable, but change it to on, off, only.

@Gustash
Copy link
Owner

Gustash commented Jun 1, 2024

Don't worry about which should take precedence over which. It's the user's fault if they provide both flags, they don't make sense together in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustash Gustash Gustash requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sryther @ProMix0 @Gustash