-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: added --freeze flag #21
Conversation
Anything wrong wit this? |
I just haven't had time to test, that's all 😅 |
I see, no stress! |
Works great for me, would love to see this merged! |
+1, would also love to see this merged |
Would also love to see this merged if you have time! |
Guys this works fine, i would be happy to use it! Add it to main repo please! |
I'll preface that I'm not actually 100% sure what is causing this. When you start a region screenshot with freeze and hit esc to cancel it, it only stops grim and hyprpicker continues running until you hit esc for the second time. |
Try #36 - there hyprpicker get killed after slurp exit |
Should be fixed now. |
hyprshot
Outdated
@@ -297,5 +306,5 @@ args $0 "$@" | |||
|
|||
SAVE_FULLPATH="$SAVEDIR/$FILENAME" | |||
[ $CLIPBOARD -eq 0 ] && Print "Saving in: %s\n" "$SAVE_FULLPATH" | |||
begin_grab $OPTION | |||
begin_grab $OPTION & checkRunning | |||
killHyprpicker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this call the killHyprpicker function at the end when checkRunning already serves that purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point actually
Adds the --freeze and -F flags, which freeze your screen upon initialization. It can be very useful when you want to screenshot something that disappears quickly!
Depends on hyprpicker, though..