Merge pull request #224 from apollographql/main

Create a new pull request by comparing changes across two branches
GulajavaMinistudio · Jan 8, 2025 · 8da2d46 · 8da2d46
2 parents d50c44c + 2944f70
commit 8da2d46
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -15,7 +15,7 @@ jobs:
 
   Lint:
     docker:
-      - image: cimg/node:23.3.0
+      - image: cimg/node:23.5.0
     steps:
       - checkout
       - run: npm version
@@ -24,15 +24,15 @@ jobs:
 
   Formatting:
     docker:
-      - image: cimg/node:23.3.0
+      - image: cimg/node:23.5.0
     steps:
       - checkout
       - run: npm ci
       - run: npm run check:format
 
   Tests:
     docker:
-      - image: cimg/node:23.3.0
+      - image: cimg/node:23.5.0
     parameters:
       project:
         type: string
@@ -53,15 +53,15 @@ jobs:
           path: reports/junit
   Attest:
     docker:
-      - image: cimg/node:23.3.0
+      - image: cimg/node:23.5.0
     steps:
       - checkout
       - run: npm ci
       - run: npm run test:type-benches
 
   BuildTarball:
     docker:
-      - image: cimg/node:23.3.0
+      - image: cimg/node:23.5.0
     steps:
       - checkout
       - run: npm run ci:precheck
@@ -80,7 +80,7 @@ jobs:
       react:
         type: string
     docker:
-      - image: cimg/node:23.3.0-browsers
+      - image: cimg/node:23.5.0-browsers
     steps:
       - checkout
       - attach_workspace:
@@ -118,7 +118,7 @@ jobs:
       externalPackage:
         type: string
     docker:
-      - image: cimg/node:23.3.0
+      - image: cimg/node:23.5.0
     steps:
       - checkout
       - attach_workspace:

diff --git a/.size-limits.json b/.size-limits.json
@@ -1,4 +1,4 @@
 {
-  "dist/apollo-client.min.cjs": 41639,
+  "dist/apollo-client.min.cjs": 41640,
   "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 34381
 }
diff --git a/src/react/hooks/__tests__/useSubscription.test.tsx b/src/react/hooks/__tests__/useSubscription.test.tsx
@@ -12,7 +12,7 @@ import {
 import { PROTOCOL_ERRORS_SYMBOL } from "../../../errors";
 import { InMemoryCache as Cache } from "../../../cache";
 import { ApolloProvider } from "../../context";
-import { MockSubscriptionLink } from "../../../testing";
+import { MockSubscriptionLink, wait } from "../../../testing";
 import { useSubscription } from "../useSubscription";
 import { spyOnConsole } from "../../../testing/internal";
 import { SubscriptionHookOptions } from "../../types/types";
@@ -1961,6 +1961,7 @@ describe("ignoreResults", () => {
       }
     );
     if (!IS_REACT_17) {
+      await wait(0);
       expect(subscriptionCreated).toHaveBeenCalledTimes(1);
     }
 
@@ -2034,6 +2035,7 @@ describe("ignoreResults", () => {
       }
     );
     if (!IS_REACT_17) {
+      await wait(0);
       expect(subscriptionCreated).toHaveBeenCalledTimes(1);
     }