Fix crash when wait-for-property fails

GuillaumeGomez · Sep 18, 2023 · 100d927 · 100d927
1 parent f6452af
commit 100d927
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/commands/wait.js b/src/commands/wait.js
@@ -752,7 +752,7 @@ function parseWaitForProperty(parser) {
     const varValue = varName + 'Value';
 
     const { checks, hasSpecialChecks } = makeExtendedChecks(
-        enabledChecks, false, 'nonMatchingAttrs', 'property', 'prop', varKey, varValue);
+        enabledChecks, false, 'nonMatchingProps', 'property', 'prop', varKey, varValue);
 
     let checker;
     if (!enabledChecks['ALL']) {

diff --git a/tests/ui-tests/wait-for-property-3.goml b/tests/ui-tests/wait-for-property-3.goml
@@ -0,0 +1,6 @@
+// This test ensures that the `wait-for-property` command is behaving like expected.
+go-to: "file://" + |CURRENT_DIR| + "/" + |DOC_PATH| + "/elements.html"
+set-timeout: 500
+// Try a property with a different type.
+// This should give a failure, not an internal error.
+wait-for-property: ("html", {"offsetLeft": "0"})
diff --git a/tests/ui-tests/wait-for-property-3.output b/tests/ui-tests/wait-for-property-3.output
@@ -0,0 +1,7 @@
+=> Starting doc-ui tests...
+
+wait-for-property-3... FAILED
+[ERROR] (line 6) Error: The following properties still don't match: [expected `0` for property `offsetLeft`, found `0`]: for command `wait-for-property: ("html", {"offsetLeft": "0"})`
+
+
+<= doc-ui tests done: 0 succeeded, 1 failed