Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back repo as GDExtension #67

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

GuilhermeGSousa
Copy link
Owner

@GuilhermeGSousa GuilhermeGSousa commented Nov 13, 2024

  • Implement AnimationNodeExtension in godot
  • Fix builds of MMAnimationNode
  • Fix CI

@GuilhermeGSousa GuilhermeGSousa self-assigned this Nov 13, 2024
@GuilhermeGSousa GuilhermeGSousa marked this pull request as draft November 13, 2024 14:34
@fire
Copy link
Collaborator

fire commented Nov 13, 2024

@fire
Copy link
Collaborator

fire commented Nov 13, 2024

@GuilhermeGSousa I propose we go in this order:

AnimationNodeExtension

There is a race to get this into the Godot Engine 4.4 version.

Bone features

While we wait, we can develop the bone feature.

godot-motion-matching GDExtension

When AnimationNodeExtension is in the Godot Engine master branch, we can work on this.

@GuilhermeGSousa
Copy link
Owner Author

@fire I have some work done in godot, I needed these changes to be able to start testing things
godotengine/godot#99181

@GeorgeS2019
Copy link

Which version of Godot 4 will work with this GDectension?

@GuilhermeGSousa
Copy link
Owner Author

Whichever version has this change
godotengine/godot#99181
so probably 4.5? I dunno

@GeorgeS2019
Copy link

Not to be unfair to you, if you could provide windows exe of this version, we could continue to follow your demo. Just a feedback

@GuilhermeGSousa GuilhermeGSousa marked this pull request as ready for review November 18, 2024 09:03
@GuilhermeGSousa GuilhermeGSousa merged commit a431daf into engine-module Nov 21, 2024
3 of 69 checks passed
@GuilhermeGSousa GuilhermeGSousa deleted the back-to-extension branch November 21, 2024 20:37
GuilhermeGSousa added a commit that referenced this pull request Dec 8, 2024
GuilhermeGSousa added a commit that referenced this pull request Dec 8, 2024
GuilhermeGSousa added a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants