Fix CI failure of PR #1989

[jcfstabile]

Downgrade pipenv to 2021.5.29

[mlouielu]

Your local branch should rebase with Guake/master. The git commits are not clean.

[mlouielu]

I believe commits still have problem, we should only get one commit log in this case.

The easiest way may be copy the hash (cf94936), reset to latest main hash, then cherry-pick the copied hash back.

[jcfstabile]

So, to be on same page you propose:

git reset 3230199
git cherry-pick cf94936
git push

am I right?

[mlouielu]

So, to be on same page you propose:

git reset 3230199 git cherry-pick cf94936 git push

am I right?

• git reset --hard HASH
• ...
• git push --force

You can check it with your git log, it should look like this:

commit 1b6918175a06b614e7f9462b0c18c11a5548eaf7 (HEAD -> pr_1990)
Author: Juan Carlos Francisco Stabile <jcfstabile@gmail.com>
Date:   Wed Dec 15 22:36:20 2021 -0300

    Downgrade pipenv version to 2021.5.29

commit 32301994813de64134200e0512ee3614eae7f66f (origin/master, origin/HEAD, master)
Author: Juan Carlos Francisco Stabile <jcfstabile@gmail.com>
Date:   Tue Dec 14 23:30:02 2021 -0300

    Add release note for bugfix on issue #1971

[jcfstabile]

Good. Thank you.

[Davidy22]

I don't have much of an issue with squashing to clean up commits, but it looks like CI is still failing. Error message:

Error: the command pytest could not be found within PATH or Pipfile's [scripts].

I remember hitting this one in my own endeavors to fix CI for pypi. My change in .github/workflows/ci.yml adding pytest pytest-cov pyfakefs to the pip install resolved this for me I think, I might have done some other things on top of that but it was a while ago now. Haven't committed this yet, still doesn't actually fix pypi yet

[Davidy22]

If it helps, you could cherry pick my changes, but I have a lot of scratch work in my repo and you might just be better off copying things where they might look relevant

[gsemet]

Can you give a try with poetry ?

[gsemet]

CI fixed in #2013

[gsemet]

upgrading pipenv is not possible (setuptools, ...). Using poetry will fix this issue