Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module gi not found when make run #1989

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Fix module gi not found when make run #1989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
845c7bb
Change pipenv install version to 2021.11.23
jcfstabile Dec 15, 2021
e9aca31
Add --site-package flag on pipenv-install-dev Makefile rule
jcfstabile Dec 15, 2021
8471da7
Add release note for bugfix on issue #1971
jcfstabile Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ dev-no-pipenv: clean
. .venv/bin/activate && pip install -r requirements.txt -r requirements-dev.txt -e .

pipenv-install-dev:
PIPENV_IGNORE_VIRTUALENVS=1 pipenv install --dev --python $(PYTHON_INTERPRETER)
PIPENV_IGNORE_VIRTUALENVS=1 pipenv install --dev --python $(PYTHON_INTERPRETER) --site-packages

ln-venv:
# use that to configure a symbolic link to the virtualenv in .venv
Expand Down
3 changes: 3 additions & 0 deletions releasenotes/notes/bugfix-gi-not-found-when-make-run-c30cf8be36345384.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
fixes:
- Fix issue, At local execution of guake (without system-wide install), at start up, it break showing that cant found module named 'gi' #1971

2 changes: 1 addition & 1 deletion scripts/bootstrap-dev-pip.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ fi

python3 -m pip install $op --upgrade \
'pip==20.0.2' \
'pipenv==2018.11.26' \
'pipenv==2021.11.23' \
|| echo "you may need to sudo me !"

echo "Please ensure your local bin directory is in your path"
Expand Down