Storage reduction pass #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 12, 2020 15:31
This reverts commit 944bc5c.
added 7 commits
October 21, 2020 16:35
|
Could this be changed to use the |
|
Thank you, I will look at using masks. |
added 9 commits
November 23, 2020 07:32
jdahm
requested changes
Dec 9, 2020
There was a problem hiding this comment.
Getting there. Needs support for 1D fields and masks (eddie-c-davis#5)
src/gt4py/backend/debug_backend.py
Outdated
| offset = "{:+d}".format(node.offset[ax]) if ax in node.offset else "" | ||
| index.append("{ax}{offset}".format(ax=ax, offset=offset)) | ||
|
|
||
| # Extend index with zeros... | ||
| index.extend(["0"] * (len(self.block_info.extent) - len(index))) |
There was a problem hiding this comment.
This should use the filter_mask or NumericTuple.from_mask after merging.
Comment on lines
125
to
126
| for i in range(len(extent) - len(axes)): | ||
| shape += ", 1" |
| {%- endfor %} | ||
| {% set arg_counter = arg_counter + arg_fields|length %} | ||
| {% for param in parameters %} | ||
| using p_{{ param.name }} = gt::arg<{{ arg_counter + loop.index0 }}, gt::global_parameter<{{ param.dtype }}>>; | ||
| using p_{{ param.name }} = gt::arg<{{ arg_counter + loop.index0 }}, gt::global_parameter<backend_t, {{ param.dtype }}>>; |
There was a problem hiding this comment.
Is backend_t is needed here? You may have gotten this at one point from one of my PRs, but I'm not sure it's really needed after all.
| @@ -160,11 +183,12 @@ auto make_grid(const std::array<gt::uint_t, 3>& compute_domain_shape) { | |||
| } | |||
|
|
|||
|
|
|||
| {%- for axes in used_axes %} | |||
| {%- if axes.name == "ijk" %} | |||
1 task
|
Replaced with temp-storage-reduce branch so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an optimization pass that reduces three dimensional temporary storages (IJK) to two dimensions (IJ) whenever possible.