feat[next]: Add support for more datatypes #1786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar_type to avoid duplication
havogt
reviewed
Jan 14, 2025
| @@ -192,13 +192,13 @@ class UniqueInitializer(DataInitializer): | |||
| data containers. | |||
| """ | |||
|
|
|||
| start: int = 0 | |||
| start: int = 1 | |||
There was a problem hiding this comment.
I might have added a test that relies on start being zero, which is a mistake. Let me know if you see a problem.
tehrengruber
approved these changes
Jan 17, 2025
src/gt4py/next/program_processors/codegens/gtfn/itir_to_gtfn_ir.py
Outdated
Show resolved
Hide resolved
| @@ -318,7 +318,9 @@ def testee(a: int32, b: int32, c: cases.IField) -> cases.IField: | |||
| # not inlined | |||
| return tmp2 * tmp2 * c | |||
|
|
|||
| cases.verify_with_default_data(cartesian_case, testee, ref=lambda a, b, c: a * b * a * b * c) | |||
| cases.verify_with_default_data( | |||
There was a problem hiding this comment.
This test erroneously passed before since verify_with_default_data used 0 for a which made the entire expression 0.
I checked them and they look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PR#1708 without the
float16andbfloat16changes.Add support for
int8, uin8, int16, uint16, uint32anduint64.Move builtin definitions from
src/gt4py/next/iterator/ir.pytosrc/gt4py/next/iterator/builtins.py.Use ascending integer values in
ScalarKind-Enum and modify tests respectively.Set
start: int = 1intests/next_tests/integration_tests/cases.pyto not start initialization from zero as this has the same value as zero-initialized memory and modify tests respectively.