feat[next]: Support for direct field operator call with domain arg #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehrengruber
commented
Dec 10, 2024
| ) | ||
| return tuple(rewritten_args), tuple(size_args), kwargs | ||
|
|
||
|
|
||
| def _field_constituents_shape_and_dims( | ||
| def _field_constituents_range_and_dims( |
There was a problem hiding this comment.
This part of the code-base is in an extremely poor state, let's not prettify a blobfish and invest time on improving this here.
…not start at zero
…ll_with_domain_arg
…zero_domain_start' into field_arg_with_non_zero_domain_start
…ll_with_domain_arg
…zero_domain_start' into field_arg_with_non_zero_domain_start
|
|
havogt
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for directly calling a field operator with a domain argument, which was previously only supported inside of a program. Many field operators in icon4py use the domain argument resulting in excessive amounts of boilerplate programs that can be removed now.
Support in the dace backend is missing and will be added in a seperate PR.