fix[cartesian]: Fix serialize default behavior when Pickled property was not saved #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Poke @romanc |
|
It seems related to the change I made to the test code tests/cartesian_tests/integration_tests/multi_feature_tests/test_dace_parsing.py when I upgraded the DaCe package version. Is it possible that with your fix we can undo my change? |
romanc
reviewed
Sep 4, 2024
Remove previous test fix for dace parsing
Should be, pushing code now |
romanc
reviewed
Sep 4, 2024
Co-authored-by: Roman Cattaneo <romanc@users.noreply.github.com>
twicki
approved these changes
Sep 4, 2024
edopao
approved these changes
Sep 5, 2024
edopao
pushed a commit
to edopao/gt4py
that referenced
this pull request
Sep 6, 2024
…was not saved (GridTools#1629) ## Description DaCe has a behavior of _not_ saving properties if they have a default (newish behavior) which leads our 2-step process of library node caching to fail. Since we have decided to rely on pickling to cache out the content of the LibraryNode we respond to this change in DaCe by making sure default values pass to the pickle deserializer are returned plain ## Requirements - [ ] All fixes and/or new features come with corresponding tests. - [ ] Important design decisions have been documented in the approriate ADR inside the [docs/development/ADRs/](docs/development/ADRs/Index.md) folder. --------- Co-authored-by: Florian Deconinck <florian.deconinck@gmail.com> Co-authored-by: Roman Cattaneo <romanc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DaCe has a behavior of not saving properties if they have a default (newish behavior) which leads our 2-step process of library node caching to fail. Since we have decided to rely on pickling to cache out the content of the LibraryNode we respond to this change in DaCe by making sure default values pass to the pickle deserializer are returned plain
Requirements