-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[next]: as_offset implementation in embedded #1397
Open
nfarabullini
wants to merge
45
commits into
GridTools:main
Choose a base branch
from
nfarabullini:as_offset_embedded
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
5b6b8b7
as_offset implementation in embedded
nfarabullini 81c0141
Merge branch 'main' into as_offset_embedded
nfarabullini 1acb1d8
edit to exclusion_matrices
nfarabullini b94e81c
edit to exclusion_matrices
nfarabullini f815712
resolved some pre-commit errors
nfarabullini 67f8117
resolved some pre-commit errors
nfarabullini e17ff41
implemented EXPERIMENTAL_FUN_BUILTIN_NAMES
nfarabullini 0e61be2
edits for as_offset
nfarabullini 0219e72
additional cleanup
nfarabullini 762d7eb
additional cleanup
nfarabullini fa1c588
reverted a couple of edits
nfarabullini 38c052c
ran pre-commit
nfarabullini e8d6e5e
edit to test
nfarabullini 782375b
edit for md dimensional field
nfarabullini 654b14d
replaced connectivity with restricted
nfarabullini 186b81d
edit to as_offset in experimental
nfarabullini e50eb64
small clenaup
nfarabullini 09a4c44
updated code to checked vars
nfarabullini 9f2bcc6
ran pre-commit
nfarabullini 90f6796
removed [0][0] indexing
nfarabullini b19ba78
edits for tests and others for as_offset
nfarabullini c5464f3
edits to test
nfarabullini 7c3e9cb
ran pre-commit
nfarabullini 2ea83f1
edits
nfarabullini 6387049
edits for other offsets
nfarabullini 1e892b4
changes to path
nfarabullini 2f3d9f6
edit for dace backend
nfarabullini b941b92
update with main
nfarabullini 81fc838
trout attempt for fieldoffset in cache
nfarabullini 7261ae7
edit suggested by Edoardo
nfarabullini ba1a91f
edit to offset_invariants
nfarabullini e074b10
edits following Hannes' review
nfarabullini ea7f20f
ran pre-commit
nfarabullini c483a0f
commented test out
nfarabullini b363cc2
placed test back
nfarabullini 391508b
edit to failing test
nfarabullini c668dc8
Update tests/next_tests/integration_tests/feature_tests/ffront_tests/…
nfarabullini 83a4b38
Merge branch 'main' of https://github.com/nfarabullini/gt4py into as_…
nfarabullini 7e26c20
edits to dimensions refactoring
nfarabullini 8bc6725
minor cleanup
nfarabullini e3e8db8
edit to test
nfarabullini 5b6e553
Merge branch 'ruff-config' into as_offset_embedded
egparedes dacc6d5
Merge new style lint config
egparedes 34fdeb7
Merge branch 'ruff-config' into as_offset_embedded
egparedes 84abf3d
Recover deleted pieces after merging with main
egparedes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
edit to offset_invariants
- Loading branch information
commit ba1a91f5d5c5bc9ea4f2c8fdaab15206bba72673
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are the changes in this file needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as_offset
was breaking with the dace backend. These changes were discussed with @edopao and @petiaccjaThe dace backend does not consider
offset_dim
to compute the key to access the build cacheThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have included this change in one of my PRs, which I have already merged. So you won't need to do any change in this file after you rebase (but you'll get a rebase conflict).