feat[next] Enable GPU backend tests #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
779d60a to
5c179a1
Compare
egparedes
reviewed
Nov 17, 2023
|
I reviewed @DropD 's changes. Did you review mine? |
havogt
commented
Nov 17, 2023
havogt
commented
Nov 17, 2023
DropD
previously approved these changes
Nov 17, 2023
havogt
commented
Nov 17, 2023
Comment on lines
127
to
130
| if hasattr(value, "__array__") or hasattr(value, "__getitem__"): | ||
| raise ValueError( | ||
| "`ConstInitializer` can not be used with non-scalars. Use `Case.as_field` instead." | ||
| ) |
There was a problem hiding this comment.
Suggested change
| if hasattr(value, "__array__") or hasattr(value, "__getitem__"): | |
| raise ValueError( | |
| "`ConstInitializer` can not be used with non-scalars. Use `Case.as_field` instead." | |
| ) | |
| if not core_defs.is_scalar_type(value): | |
| raise ValueError( | |
| "`ConstInitializer` can not be used with non-scalars. Use `Case.as_field` instead." | |
| ) |
| class ConstInitializer(DataInitializer): | ||
| """Initialize with a given value across the coordinate space.""" | ||
|
|
||
| value: ScalarValue | ||
|
|
||
| def __init__(self, value: ScalarValue): |
There was a problem hiding this comment.
Suggested change
| def __init__(self, value: ScalarValue): | |
| def __init__(self, value: core_defs.Scalar): |
There was a problem hiding this comment.
and remove ScalarValue completely
There was a problem hiding this comment.
... but kept ScalarValue pointing to core_defs.Scalar as this seems to be the pattern that is used in this field
| mask = cases.allocate(cartesian_case, conditional_nested_tuple, "mask").strategy( | ||
| cases.ConstInitializer(bool_field) | ||
| )() | ||
| mask = cartesian_case.as_field([IDim], np.random.choice(a=[False, True], size=size)) |
There was a problem hiding this comment.
could we built in to cases that boolean fields are allocated with alternating values by default?
There was a problem hiding this comment.
maybe in a follow-up PR to get the GPU support in
|
will merge now as no one complained about my last changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.