Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature[next] GPU backend from Python #1325

Merged
merged 16 commits into from
Oct 24, 2023
Merged

feature[next] GPU backend from Python #1325

merged 16 commits into from
Oct 24, 2023

Conversation

petiaccja
Copy link
Contributor

No description provided.

@petiaccja petiaccja mentioned this pull request Aug 17, 2023
Closed
DropD
DropD reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@DropD DropD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some design / infrastructure questions, which I want to make sure we have given due consideration.

tests/next_tests/integration_tests/feature_tests/ffront_tests/test_gpu_backend.py Show resolved Hide resolved
src/gt4py/next/otf/compilation/build_systems/cmake_lists.py Show resolved Hide resolved
src/gt4py/next/otf/compilation/build_systems/cmake_lists.py Show resolved Hide resolved
havogt
havogt reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw that long time ago I started a review and had these 2 comments pending. please check if they still make sense.

src/gt4py/next/program_processors/codegens/gtfn/gtfn_module.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/gtfn_cpu.py Outdated Show resolved Hide resolved
@havogt havogt changed the title [feature][next] GPU backend from Python feature[next] GPU backend from Python Sep 7, 2023
DropD
DropD approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@DropD DropD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now.

@DropD DropD merged commit af7ff8a into GridTools:main Oct 24, 2023
@havogt havogt mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havogt havogt havogt left review comments

@DropD DropD DropD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petiaccja @DropD @havogt