Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[next] high-level field storage API #1319

Merged
merged 288 commits into from
Nov 15, 2023
Merged

feat[next] high-level field storage API #1319

merged 288 commits into from
Nov 15, 2023

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Aug 15, 2023 •
edited by egparedes
Loading

Introduce user API to allocate fields in gt4py.next.

Summary of main changes:

  • Introduce FieldBuffer allocator protocols and implementations
  • Introduce the concept of Backend as ProgramExecutor & Allocator
  • Replace np_as_located_field with as_field
  • Make NdArrayField public
  • Fixes for _core.definitions typings
  • Fixes and extensions of eve.extended_typing
  • Refactor the handling of backends/program processors in the testing infrastructure with string enumerations representing the qualified name of the Python symbol, which can be loaded on demand
  • Rename some executor symbols and modules
  • Minor style changes to imports and imported symbols to follow coding guidelines.

Open"To Do"s for future PRs:

  • Add support for GTFieldInterface protocol in cartesian and use it instead of NextGTDimsInterface protocol in next.
  • Add support for aligned_index != None in FieldBufferAllocator implementations
  • Add support for zero-copy construction of fields in constructors.as_field()

havogt and others added 30 commits August 3, 2023 07:39
@havogt
Merge remote-tracking branch 'origin/main' into embedded-field-view-impl
c6fc23e
@havogt
Merge remote-tracking branch 'upstream/embedded-field-view-impl' into…
76ab3ab 
… hacked_iterator_embedded_with_field
@havogt
Merge remote-tracking branch 'upstream/embedded-field-view-impl' into…
b9f2f2c 
… hacked_iterator_embedded_with_field
@havogt
refactor[next]: iterator.embedded field_set/getitem accept named indices
9f26f80
@havogt
new typealiases
d236b5a
@havogt
Merge remote-tracking branch 'upstream/main' into hacked_iterator_emb…
816a637 
…edded_with_field
@havogt
Merge remote-tracking branch 'origin/small_embedded_refactoring' into…
ab1bac8 
… hacked_iterator_embedded_with_field
@havogt
- remove runtime.Offset Dimension
d113210 
- in embedded use dict[Dimension, Index] instead of dict[Tag, Index] as position
@havogt
smaller hack
bea8f65
@havogt
Merge remote-tracking branch 'origin/small_embedded_refactoring' into…
140c80f 
… hacked_iterator_embedded_with_field
@havogt
a bit of refactoring
4bceb83
@havogt
missing import
44a26c2
@samkellerhals
Introduce Fieldview Domain (GridTools#1310)
a8a0324
@havogt @tehrengruber
Apply suggestions from code review
d3a7e44 
Co-authored-by: Till Ehrengruber <till.ehrengruber@cscs.ch>
@havogt
fix test
aab3436
@havogt
fix imports
202fc3b
@havogt
fix import
60b2534
@samkellerhals
Add domain slicing
c0fe349
@havogt
Merge remote-tracking branch 'upstream/embedded-field-view-impl' into…
0108cd0 
… hacked_iterator_embedded_with_field
@havogt
fix import
4fbf5f6
@havogt
undo tag->dimension
4c34135
@havogt
Merge remote-tracking branch 'upstream/embedded-field-view-impl' into…
6612a70 
… hacked_iterator_embedded_with_field
@havogt
Merge remote-tracking branch 'origin/small_embedded_refactoring' into…
eb152eb 
… hacked_iterator_embedded_with_field
@samkellerhals
fix _slice_with_domain
e41619a
@havogt
fix bug
1c423da
@samkellerhals
Add field intersection binary op test
01c452a
@havogt
translate tag to Dimension
0085223
@samkellerhals
Ensure matching dimensions and ranges in Domain
a49e3cb
@havogt
fix some test
61c3ae6
@havogt
make field view work
ad5e4b2
@egparedes
Copy link
Contributor

egparedes commented Nov 14, 2023 •
edited
Loading

I propose we document all TODOs

Added open TODOs to the PR description

@nfarabullini nfarabullini force-pushed the field_storage_interface branch from 9ae9533 to a53710a Compare November 14, 2023 10:47
egparedes and others added 3 commits November 14, 2023 17:12
@egparedes
Typo
739604e
@egparedes
Address open reviewer's comments in test_constructors
bfbc65c
fix field constructor tests
2dc0cfc 
- rename vars so that the reference is `ref`, not the result of the
  tested function

- fix missing equality test in assert statement in `test_empty`
@DropD
Copy link
Contributor

DropD commented Nov 15, 2023

cscs-ci run

@havogt havogt merged commit 0df592d into GridTools:main Nov 15, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes egparedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@havogt @egparedes @DropD @samkellerhals @nfarabullini