-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add RetryInterceptor to print detailed error #4434
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4434 +/- ##
==========================================
- Coverage 85.02% 84.75% -0.28%
==========================================
Files 1075 1075
Lines 192542 192560 +18
==========================================
- Hits 163709 163201 -508
- Misses 28833 29359 +526 |
Not necessary. |
b2f3203
to
560d32c
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As the issue mentions, we want to print detailed messages when an error occurs to help us troubleshoot.
The PR adds the
PrintDetailedError
, which implementsRetryInterceptor
to printError
inDebug
format in retrying.@evenyag Do we need a configuration to control whether we add the
RetryInterceptor
?Checklist