Correct failure to remove empty fluid stacks from MEPatternPartMachine #2859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We're playing Monifactory and noticed that ME Pattern Buffers that use Fluids sometimes jam. The jam is much more likely when multiple fluids are in play across multiple patterns. When crafts jam, we notice that
0 mb
of Air is left inside the ME Pattern Buffer. We suspect that it is causing recipes to not be crafted because they do not use Air - or maybe that everyfluidInventory
is already full of another fluid.It could also just be visual though.
We only see the Air after pressing the
Return
button which maps to therefund()
functionImplementation Details
This change also removes empty fluids from the internal
fluidInventory
when they are empty.Outcome
Should cause empty fluid stacks to be removed from ME Pattern Buffers
Additional Information
This section is for screenshots to demonstrate any GUI or rendering changes, or any other additional information that reviewers should be aware of.
Potential Compatibility Issues
This section is for defining possible compatibility issues. It must be used when there are API changes, item/block/material/machine changes, or recipe changes.
Please fill in as much useful information as possible. Also, please remove all unused sections, including this and the other explanations.