Add initial computercraft support. #2792
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is ready for review. It is definitely very minimal, but is usable as-is. It also partly covers a gap in the KubeJS implementation, as the support for energy containers does not support the power substation. |
|
Resolve the merge conflicts and ping me on discord if I don't notice |
jtuc
reviewed
Feb 7, 2025
|
|
||
| private static BigInteger MAX_LONG = BigInteger.valueOf(Long.MAX_VALUE); | ||
|
|
||
| private static MethodResult toResult(BigInteger val) { |
There was a problem hiding this comment.
Lua treats all numbers as doubles, so there's no advantage to special-casing small values.
In CC:Tweaked specifically, values are converted by calling java.lang.Number#doubleValue(), so you can just pass the BigInteger into MethodResult.of() directly.
https://github.com/cc-tweaked/CC-Tweaked/blob/mc-1.20.x/projects/core/src/main/java/dan200/computercraft/core/lua/CobaltLuaMachine.java#L177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This add computercraft support to some energy containers.
See #806.
Outcome
EU energy containers (including power substations) now can be queried for their stored energy and energy capacity.
Additional Information
Potential Compatibility Issues
The names and ids defined for peripherals are exposed to lua code, so changing them in the future will cause compatibility issues.