For comparing unordered collections - respect settings for casesensit… #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivity and treat null and string.empty as same
|
It will take me several days to do a build. I am just swamped with managing three projects at my day job and side business. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ivity and treat null and string.empty as same
Hi - had some trouble with Compare.Net when comparing arrays of objects where some properties on the objects was string.empty on one end and null on the other.... Found similar problems with casesensitivity
Basically config.IgnoreCollectionOrder = true did not work well with config.TreatStringEmptyAndNullTheSame = true or config.CaseSensitive = false.
Se included tests - that will fail without my fix...
Would be nice if this one could be accepted and a new nuget package published- as it would fix mentioned problems in another project im working on..
Please review my changes.