Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Path tool support for G/R/S rotation and scaling with a single selected handle #2180

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Add Path tool support for G/R/S rotation and scaling with a single selected handle #2180

merged 4 commits into from
Jan 15, 2025

Conversation

0SlowPoke0
Copy link
Contributor

@0SlowPoke0 0SlowPoke0 commented Jan 6, 2025 •
edited by Keavon
Loading

Partly closes #1870 and also some minor improvements

  • When using the path tool, R/S works about the anchor when a single handle is selected.
  • When using the pen tool, Backspace/Delete removes the current segment's handle (equivalent to clicking the current anchor).

Minor improvements as discussed -

  • G/R/S should have no effect (those keys should be ignored) while in the yellow point insertion sliding state - discord
  • The global G/R/S is actually specific to the Select tool and Path tool - discord
  • G/R/S when the selection is empty should not activate G/R/S (A layer is selected but not any points in it.) - discord
  • Aborts from G/R/S when switching tools using hotkeys - discord

@Keavon
Copy link
Member

Keavon commented Jan 6, 2025

!build

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

📦 Build Complete for 780ddf5
https://f36c6976.graphite.pages.dev

@0SlowPoke0 0SlowPoke0 force-pushed the pen_and_path_tools_fix branch from 6c0881b to 812bdec Compare January 9, 2025 12:35
@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review January 10, 2025 13:59
@Keavon Keavon force-pushed the pen_and_path_tools_fix branch from 812bdec to ab55281 Compare January 10, 2025 21:59
@Keavon Keavon changed the title Rotation and Scaling for Single Handle Selection Add Path tool support for G/R/S rotation and scaling with a single selected handle Jan 10, 2025
@Keavon
Copy link
Member

Keavon commented Jan 10, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for ab55281
https://366fb012.graphite.pages.dev

@Keavon Keavon force-pushed the pen_and_path_tools_fix branch from ab55281 to ba3cc5a Compare January 13, 2025 02:49
@Keavon
Copy link
Member

Keavon commented Jan 13, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for ba3cc5a
https://6c09c4a5.graphite.pages.dev

@0SlowPoke0 0SlowPoke0 force-pushed the pen_and_path_tools_fix branch from ba3cc5a to cc033f4 Compare January 14, 2025 11:33
@Keavon Keavon force-pushed the pen_and_path_tools_fix branch from cc033f4 to d0c80e2 Compare January 15, 2025 08:25
@Keavon Keavon enabled auto-merge (squash) January 15, 2025 08:29
@Keavon Keavon mentioned this pull request Jan 15, 2025
Open
24 tasks
@Keavon Keavon merged commit 2e4fb95 into GraphiteEditor:master Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon Keavon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Pen and Path tool improvements
2 participants
@0SlowPoke0 @Keavon