Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line tool drawing with start and end points #2178

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

November-6
Copy link
Contributor

Closes #2090

This isnt a proper fix for the issue but a starting point for it.

I have moved the layer and node creation to when the dragstop message fires. This way we have the starting and end points with us when we want to draw the line.
But, with this approach the line preview is not being shown i.e i cant see the line being formed as im drawing it. I only see it once i release click.
Please provide help with how to get started with implementing a preview of line as well as the snapping and angle functionality.

@Keavon
Copy link
Member

Keavon commented Jan 5, 2025

Welcome back! In regards to your quoted text, how does that relate to the current situation after your rollback? What is the status of the code as you've committed it presently?

@November-6
Copy link
Contributor Author

The current code implements the required functionality in its most basic form, it draws a line based on starting and end points. Although preview drawing of line and shift ctrl functionalities are lost which i need help introducing again. You can see this in the issues tab where I presented a screen recording of it. The code is (mostlyyyyy) in the same state as it was when I uploaded that video.

The rollback I referred to was from a solution to a node problem I was having where I tried to use Rc/Arc to reference the node instead of passing it directly into nodes vector. It had its own issues so I came back to my first draft.

Also regarding the review I added is actually a bug for other tools which I recently introduced while trying to implement a preview myself. Its fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The shape tools should set shape node parameters, not transformations of unit shapes
2 participants