Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supernode: range merge function #126

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Supernode: range merge function #126

merged 2 commits into from
Apr 3, 2023

Conversation

etwest
Copy link
Collaborator

@etwest etwest commented Mar 21, 2023

Ability to merge together only some of the sketches in two Supernodes.

@etwest etwest requested a review from DanielDeLayo March 21, 2023 19:25
DanielDeLayo
DanielDeLayo approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@DanielDeLayo DanielDeLayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The range merge worries me a little bit, but I think it's probably fine. We trust user-given serialization streams, so trusting a range-merge call isn't worse.

@etwest etwest merged commit bd8cddd into main Apr 3, 2023
@etwest etwest deleted the range_merge branch April 3, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielDeLayo DanielDeLayo DanielDeLayo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etwest @DanielDeLayo