Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.1.1] Missing catch/re-throw on sto_ calls #62

Closed
lmichaelis opened this issue Mar 7, 2023 · 0 comments
Closed

[v1.1.1] Missing catch/re-throw on sto_ calls #62

lmichaelis opened this issue Mar 7, 2023 · 0 comments
Assignees
@lmichaelis
Labels
bug Something isn't working
Milestone
v2.0.0

Comments

@lmichaelis
Copy link
Member

stoi and stof calls don't handle exceptions properly. We should catch and re-throw parser_error instead

See Try/OpenGothic#421 (comment)
@lmichaelis lmichaelis self-assigned this Mar 7, 2023
@lmichaelis lmichaelis added the bug Something isn't working label Mar 7, 2023
lmichaelis added a commit that referenced this issue Mar 8, 2023
@lmichaelis
[#62] fix(archive): catch and re-throw numeric conversion errors
c7d4115
@lmichaelis lmichaelis added this to the v2.0.0 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmichaelis lmichaelis

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@lmichaelis