Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for python 3.12 #1019

Merged
merged 2 commits into from
Dec 8, 2023
Merged

support for python 3.12 #1019

merged 2 commits into from
Dec 8, 2023

Conversation

NeilHanlon
Copy link
Contributor

python3.12 removed readfp(), recommended to use read_file() instead

@NeilHanlon
Copy link
Contributor Author

Note: the if condition is to support python 2.X... not sure if that is necessary.

@ryneeverett
Copy link
Collaborator

Thanks. We've already dropped support for python-2. Please remove the if-condition (which should fix CI since you forgot to import sys) and, if you wouldn't mind, add the later python versions to .github/workflows/bugwarrior.yml. Note that the python-versions are listed two different places in the file. (I'm sure there's a smarter way to avoid that duplication but 🤷.)

@NeilHanlon
Copy link
Contributor Author

Absolutely, I can do that.

Would you like me to add all the versions between 3.9 (latest in the github action config) and 3.12, or just append 3.12 to the list?

@ryneeverett
Copy link
Collaborator

If you could add all the versions from 3.9 through 3.12 that would be great.

@NeilHanlon
add support for python 3.12
8f0cec1 
python3.12 removed `readfp()`, recommended to use `read_file()` instead

* Add versions 3.10 through 3.12 to test matrix
@ryneeverett
Copy link
Collaborator

Looking at the CI failure, it seems that yaml interprets 3.10 as a float and converts it to 3.1. I think it would be fixed by just putting "3.10" in quotes.

@ryneeverett ryneeverett mentioned this pull request Nov 20, 2023
Closed
@ryneeverett
CI: fix
c5d6874 
- avoid decimal rounding
- pull back 3.11 and 3.12 since we still have some issues to work
  through
@NeilHanlon
Copy link
Contributor Author

thanks for that - apologies that this fell off my radar

@ryneeverett
Copy link
Collaborator

No problem, it happens. I let this fall off my radar too since the repository owner opened a rival pull request and I wanted to give him a chance to get involved if he was interested.

@ryneeverett ryneeverett merged commit 0a6c9ad into GothenburgBitFactory:develop Dec 8, 2023
30 checks passed
@ralphbean
Copy link
Collaborator

Sorry for competing! Thanks for resolving @ryneeverett.

@JoshMock JoshMock mentioned this pull request Apr 30, 2024
Open
@NeilHanlon NeilHanlon deleted the patch-1 branch May 11, 2024 05:03
@ChasNelson1990 ChasNelson1990 mentioned this pull request May 13, 2024
Open
@ryneeverett ryneeverett mentioned this pull request May 25, 2024
Open
NexAdn pushed a commit to NexAdn/bugwarrior that referenced this pull request Sep 19, 2024
@NeilHanlon @ryneeverett @NexAdn
support for python 3.12 (GothenburgBitFactory#1019)
574f75b 
* add support for python 3.12

python3.12 removed `readfp()`, recommended to use `read_file()` instead

* Add versions 3.10 through 3.12 to test matrix

* CI: fix

- avoid decimal rounding
- pull back 3.11 and 3.12 since we still have some issues to work
  through

---------

Co-authored-by: ryneeverett <ryneeverett@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeilHanlon @ryneeverett @ralphbean